Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manage types internally #2845

Merged
merged 3 commits into from Oct 8, 2018
Merged

Manage types internally #2845

merged 3 commits into from Oct 8, 2018

Conversation

@tgriesser
Copy link
Member

@tgriesser tgriesser commented Oct 8, 2018

Copying the knex type definitions from DefinitelyTyped into the project.

Putting these here will be useful since we can update them as new API's are merged.

@kibertoad
Copy link
Collaborator

@kibertoad kibertoad commented Oct 8, 2018

@tgriesser @JakeGinnivan Probably we should also include types from DefinitelyTyped/DefinitelyTyped#29256

Loading

@tgriesser tgriesser merged commit b2450a9 into master Oct 8, 2018
3 checks passed
Loading
@tgriesser
Copy link
Member Author

@tgriesser tgriesser commented Oct 8, 2018

Cool, yeah. I'll merge this and then @JakeGinnivan if you want to open a PR here with the updated types we can merge that.

Loading

@JakeGinnivan
Copy link
Contributor

@JakeGinnivan JakeGinnivan commented Oct 16, 2018

@tgriesser will get it done, thanks!

Loading

@serprex
Copy link
Contributor

@serprex serprex commented Dec 11, 2018

Type definitions lack support for { alias: column } in joins & toSQL on Knex.Raw. I'll open a PR when I have time

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants