Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust typing for forUpdate()/forShare() variant with table names #2858

Merged
merged 1 commit into from Oct 14, 2018
Merged

Adjust typing for forUpdate()/forShare() variant with table names #2858

merged 1 commit into from Oct 14, 2018

Conversation

@sgoll
Copy link
Contributor

@sgoll sgoll commented Oct 13, 2018

This is a followup to #2835 that became necessary with the merge of #2845. It adjust the typing of forUpdate() and forShare() to support the new call variants with table names.

It makes it possible to call forUpdate() and forShare() in either of the following three ways:

  • forUpdate()
  • forUpdate('lorem', 'ipsum')
  • forUpdate(['lorem', 'ipsum'])
@tgriesser tgriesser merged commit cdccb12 into knex:master Oct 14, 2018
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 84.697%
Details
@tgriesser
Copy link
Member

@tgriesser tgriesser commented Oct 14, 2018

Awesome, thanks @sgoll

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants