Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for retrieving null dates #2865

Merged
merged 4 commits into from Oct 19, 2018
Merged

Add test for retrieving null dates #2865

merged 4 commits into from Oct 19, 2018

Conversation

@kibertoad
Copy link
Collaborator

@kibertoad kibertoad commented Oct 18, 2018

Looks like original issue was only with Maria dialect which we no longer support. This adds test from #1308 to make sure that other dialects don't have same problem.

fixes #1276

@kibertoad
Copy link
Collaborator Author

@kibertoad kibertoad commented Oct 19, 2018

@wubzz Do you think that having these tests in knex to guard about possible regressions in the future makes sense?

@wubzz
Copy link
Member

@wubzz wubzz commented Oct 19, 2018

@kibertoad Yes, I think it's fine. The more coverage we have, the better. Things like these aren't obvious to add tests for generally speaking, you just expect it to work out of the box. But we've had situations where things we expect simply do not work, either due to knex or even on dialect level, so imho it's good additions.

@kibertoad kibertoad requested a review from wubzz Oct 19, 2018
@wubzz
wubzz approved these changes Oct 19, 2018
@kibertoad kibertoad merged commit 8c269ca into master Oct 19, 2018
3 checks passed
3 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 84.697%
Details
@kibertoad kibertoad deleted the fix/1276-null-date-mysql branch Oct 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants