Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Execute tests on Node.js 11 #2873

Merged
merged 4 commits into from Nov 10, 2018
Merged

Execute tests on Node.js 11 #2873

merged 4 commits into from Nov 10, 2018

Conversation

@kibertoad
Copy link
Collaborator

@kibertoad kibertoad commented Oct 23, 2018

No description provided.

@kibertoad kibertoad requested a review from elhigu Oct 23, 2018
@kibertoad
Copy link
Collaborator Author

@kibertoad kibertoad commented Oct 23, 2018

Fails on sqlite dependency, issue raised: mapbox/node-sqlite3#1063

@elhigu
Copy link
Member

@elhigu elhigu commented Nov 5, 2018

Some test failures suggests that hardcoded mssql driver version is not working 🤔

@kibertoad
Copy link
Collaborator Author

@kibertoad kibertoad commented Nov 5, 2018

@elhigu Huh? What do you mean?

@elhigu
Copy link
Member

@elhigu elhigu commented Nov 5, 2018

I'm not sure, but just saw these lines during test run:
https://travis-ci.org/tgriesser/knex/jobs/445284075#L3048

@kibertoad kibertoad reopened this Nov 10, 2018
@kibertoad
Copy link
Collaborator Author

@kibertoad kibertoad commented Nov 10, 2018

@elhigu TBH, I'm more surprised that other node versions didn't fail, somehow "^4.1.0" got into our package.json which obviously resolves to latest 4.x.

@kibertoad kibertoad merged commit c3fb954 into master Nov 10, 2018
3 checks passed
3 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 84.77%
Details
@kibertoad kibertoad deleted the general/node-11-support branch Nov 10, 2018
mwilliammyers added a commit to voxjar/knex that referenced this pull request Dec 12, 2018
* Execute tests on Node.js 11

* Update dependencies

* Lock mssql version to the supported one
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants