Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version upgrade guide #2894

Merged
merged 4 commits into from Nov 16, 2018
Merged

Version upgrade guide #2894

merged 4 commits into from Nov 16, 2018

Conversation

@kibertoad
Copy link
Collaborator

@kibertoad kibertoad commented Nov 6, 2018

I've tried to include cases that are plausible to be found in real production environments. If someone have their favourite breaking change not mentioned, please let me know.

@kibertoad kibertoad requested review from tgriesser and elhigu Nov 6, 2018
@kibertoad kibertoad closed this Nov 6, 2018
@kibertoad kibertoad reopened this Nov 6, 2018
@elhigu
Copy link
Member

@elhigu elhigu commented Nov 7, 2018

Very nice 👍

@kibertoad kibertoad merged commit b341a5b into master Nov 16, 2018
3 checks passed
3 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 84.741%
Details
@kibertoad kibertoad deleted the general/upgrading-doc branch Nov 16, 2018
@kibertoad
Copy link
Collaborator Author

@kibertoad kibertoad commented Nov 16, 2018

Merged as-is, we can improve going forward.

@willmorgan
Copy link
Contributor

@willmorgan willmorgan commented Nov 21, 2018

@kibertoad Looks good!

@kibertoad
Copy link
Collaborator Author

@kibertoad kibertoad commented Nov 22, 2018

@willmorgan Thanks for checking it out!

mwilliammyers added a commit to voxjar/knex that referenced this pull request Dec 12, 2018
* Version upgrade guide

* Use more consistent style

* Slightly improve wording

* Add reference to upgrading instructions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants