Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for specifying explicit pg version #2895

Merged
merged 1 commit into from Nov 7, 2018

Conversation

@kibertoad
Copy link
Collaborator

@kibertoad kibertoad commented Nov 6, 2018

No description provided.

elhigu
elhigu approved these changes Nov 7, 2018
Copy link
Member

@elhigu elhigu left a comment

I'm pretty sure, there were some tests for this already, but most probably these are more covering :)

@kibertoad
Copy link
Collaborator Author

@kibertoad kibertoad commented Nov 7, 2018

@elhigu Tried to find something like this, but couldn't find anything that would be setting {version} option for the knex in tests. Have I missed it somewhere?

@kibertoad kibertoad merged commit 1bc24df into master Nov 7, 2018
3 checks passed
@kibertoad kibertoad deleted the general/check-version-tests branch Nov 7, 2018
@elhigu
Copy link
Member

@elhigu elhigu commented Nov 7, 2018

I went to look the code, that implements version support, checked commit where it was written with "Blame" and found this: https://github.com/tgriesser/knex/pull/1993/files

@elhigu
Copy link
Member

@elhigu elhigu commented Nov 7, 2018

Git archeology :D

@kibertoad
Copy link
Collaborator Author

@kibertoad kibertoad commented Nov 7, 2018

Ahahahaha, yeah.
Aha, so there are tests, but they cover different ground (branching in internal logic based on version) and not version resolution logic per se, so there doesn't seem to be direct overlap, hence makes sense to keep new tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants