Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix knexfile resolution. Add missing test #2923

Merged
merged 5 commits into from Nov 22, 2018
Merged

Conversation

@kibertoad
Copy link
Collaborator

@kibertoad kibertoad commented Nov 21, 2018

No description provided.

@elhigu
elhigu approved these changes Nov 22, 2018
Copy link
Member

@elhigu elhigu left a comment

Looks good I guess :)

@kibertoad kibertoad merged commit 461868b into master Nov 22, 2018
3 checks passed
3 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 84.89%
Details
@kibertoad kibertoad deleted the fix/knexfile-resolution branch Nov 22, 2018
mwilliammyers added a commit to voxjar/knex that referenced this pull request Dec 12, 2018
* Fix knexfile resolution. Add missing test

* Try fixing Jake test execution

* Avoid having non-test files in jake folder

* Fix test compatibility with Node 6

* Fix the fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants