Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typings #2960

Merged
merged 5 commits into from Jan 4, 2019
Merged

Fix typings #2960

merged 5 commits into from Jan 4, 2019

Conversation

@serprex
Copy link
Contributor

@serprex serprex commented Dec 17, 2018

Updated the typings with ways which knex's API seems to allow for given our existing code. These were previously not covered by DefinitelyTyped

@AmauriAires
Copy link

@AmauriAires AmauriAires commented Jan 4, 2019

I reviewed it and made a few changes. It should work properly now.

@kibertoad
Copy link
Collaborator

@kibertoad kibertoad commented Jan 4, 2019

Thanks!

@kibertoad kibertoad merged commit 83fcefe into knex:master Jan 4, 2019
2 checks passed
@AmauriAires
Copy link

@AmauriAires AmauriAires commented Jan 4, 2019

You're welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants