Implemented extra boolean param for rollback() #2968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extra parameter allows all migrations to be rolled back.
kibertoad
reviewed
Dec 20, 2018
test/integration/migrate/index.js
Outdated
| }); | ||
|
|
||
| it('should delete all batches from the migration log', function() { | ||
| debugger; |
There was a problem hiding this comment.
probably this shouldn't be committed :)
kibertoad
reviewed
Dec 20, 2018
test/integration/migrate/index.js
Outdated
| }); | ||
| }); | ||
|
|
||
| it('should delete all batches from the migration log', function() { |
There was a problem hiding this comment.
why not use arrow function?
There was a problem hiding this comment.
well yeah when it's needed, but when it's not?..
kibertoad
reviewed
Dec 20, 2018
test/integration/migrate/index.js
Outdated
| true | ||
| ) | ||
| .spread(function(batchNo, log) { | ||
| console.log(`Batch ${batchNo}, log: ${JSON.stringify(log)}`); |
kibertoad
reviewed
Dec 20, 2018
| @@ -829,7 +829,7 @@ declare namespace Knex { | |||
| interface Migrator { | |||
| make(name: string, config?: MigratorConfig): Bluebird<string>; | |||
| latest(config?: MigratorConfig): Bluebird<any>; | |||
| rollback(config?: MigratorConfig): Bluebird<any>; | |||
| rollback(config?: MigratorConfig, all?: boolean): Bluebird<any>; | |||
|
Could you also create a PR in documentation repo? |
|
LGTM, we can merge it after documentation is created. |
kibertoad
approved these changes
Dec 20, 2018
|
@kibertoad Great! The docs PR is at knex/documentation#170 |
|
Thank you a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extra parameter allows all migrations to be rolled back.
Addresses #2844