Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "constraintName" arg to TS definition #3006

Merged
merged 1 commit into from Jan 22, 2019

Conversation

@fmenegossi
Copy link
Contributor

@fmenegossi fmenegossi commented Jan 21, 2019

Add constraintName optional argument to TableBuilder.primary() TypeScript definition.
Currently, if you give the second argument, TS will tell that primary() expects only 1 argument, when in fact it supports the second optional argument to define the constraint name into the database.

Add constraintName optional argument to TableBuilder.primary() TypeScript definition.
Currently, if you give the second argument, TS will tell that primary() expects only 1 argument, when in fact it supports the second optional argument to define the constraint name into the database.
@kibertoad kibertoad merged commit 4f8cf79 into knex:master Jan 22, 2019
2 checks passed
@kibertoad
Copy link
Collaborator

@kibertoad kibertoad commented Jan 22, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants