Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

schemaName is missing in MigratorConfig typings #3016

Merged
merged 2 commits into from Jan 28, 2019
Merged

schemaName is missing in MigratorConfig typings #3016

merged 2 commits into from Jan 28, 2019

Conversation

@mmouterde
Copy link
Contributor

@mmouterde mmouterde commented Jan 28, 2019

add a schemaName value to MigratorConfig.

add a schemaName value to MigratorConfig.
@@ -829,6 +829,7 @@ declare namespace Knex {
extension?: string;
tableName?: string;
disableTransactions?: boolean;
schemaName?: string;
Copy link
Collaborator

@kibertoad kibertoad Jan 28, 2019

since you are changing it anyway, could you please also add

sortDirsSeparately : optional boolean
and update directory one to support both String and String[]?

Copy link
Contributor Author

@mmouterde mmouterde Jan 28, 2019

Absolutely !

There is other diff with Doc :

  • loadExtensions, migrationSource are in doc, not in code
  • database is in code, not in doc.

- change type of `directory` from `string` to `string | string[]`
- add `sortDirsSeparately` as boolean optional config.
@kibertoad kibertoad merged commit a2b7e0e into knex:master Jan 28, 2019
2 checks passed
@kibertoad
Copy link
Collaborator

@kibertoad kibertoad commented Jan 28, 2019

Thanks a lot! Would be nice to address these discrepancies too.

@mmouterde
Copy link
Contributor Author

@mmouterde mmouterde commented Jan 30, 2019

@kibertoad Do you plan to release a version including this PR ?

@kibertoad
Copy link
Collaborator

@kibertoad kibertoad commented Jan 30, 2019

Unfortunately, I don't have permissions to publish knex artefacts. @elhigu would be a better person to ask.

@elhigu
Copy link
Member

@elhigu elhigu commented Jan 31, 2019

I just published 0.16.4-next1 pre-release for testing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants