Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add intersect() #3023

Merged
merged 3 commits into from Mar 3, 2019
Merged

add intersect() #3023

merged 3 commits into from Mar 3, 2019

Conversation

@thekuom
Copy link
Contributor

@thekuom thekuom commented Jan 31, 2019

Addresses #2064

I needed INTERSECT for one of my projects so I used the existing UNION as a model, since they are extremely similar. Thanks for the great library!

@thekuom
Copy link
Contributor Author

@thekuom thekuom commented Jan 31, 2019

Documentation PR: knex/documentation#173

Copy link
Member

@elhigu elhigu left a comment

Some tests verifying that generated queries actually works against real databases should be added.

test/integration/builder/unions.js Show resolved Hide resolved
test/integration/builder/unions.js Outdated Show resolved Hide resolved
test/integration/builder/unions.js Outdated Show resolved Hide resolved
test/unit/query/builder.js Outdated Show resolved Hide resolved
test/unit/query/builder.js Outdated Show resolved Hide resolved
types/knex.d.ts Outdated Show resolved Hide resolved
@kibertoad
Copy link
Collaborator

@kibertoad kibertoad commented Mar 3, 2019

Looks good, thank you!

@kibertoad kibertoad merged commit 71e097b into knex:master Mar 3, 2019
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants