.returning() does not have any effect.
In SQLite3, users can be warned that
For consistency, how about MySQL users to be warned as well?
The text was updated successfully, but these errors were encountered:
eldridge pushed a commit to eldridge/js-data-sql that referenced this issue
Jan 15, 2020
Knex 0.16.4 began warning when the returning attribute is supplied for dialects that do not support it. These dialects currently include MySQL and SQLite3. Supplying this attribute is a no-op for those dialects, so excluding them is safe and eliminates the warning. More information: knex/knex#3039
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments.