Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include 'string' as accepted Knex constructor type definition #3105

Merged
merged 1 commit into from Mar 12, 2019
Merged

Include 'string' as accepted Knex constructor type definition #3105

merged 1 commit into from Mar 12, 2019

Conversation

@enapupe
Copy link
Contributor

@enapupe enapupe commented Mar 12, 2019

Hopefully I got it right this time!

Allowing Knex() to accept string type as it does accept string configuration parameter: https://github.com/tgriesser/knex/blob/master/src/knex.js#L12

@kibertoad
Copy link
Collaborator

@kibertoad kibertoad commented Mar 12, 2019

Beautiful. Thank you!

@kibertoad kibertoad merged commit de1c934 into knex:master Mar 12, 2019
2 checks passed
@enapupe
Copy link
Contributor Author

@enapupe enapupe commented Mar 12, 2019

Thanks for being so responsive!

@kibertoad
Copy link
Collaborator

@kibertoad kibertoad commented Mar 12, 2019

haha, np!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants