Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix queryContext not being passed to raw queries #3111

Merged
merged 2 commits into from Mar 18, 2019

Conversation

@kibertoad
Copy link
Collaborator

@kibertoad kibertoad commented Mar 17, 2019

fixes #3110

@kibertoad kibertoad requested a review from koskimas Mar 17, 2019
elhigu
elhigu approved these changes Mar 18, 2019
Copy link
Member

@elhigu elhigu left a comment

I suppose this is fine, I'm a bit confused with .raw query builder right now, since it seems a bit too much diverted from normal builders.

Just to be safe would be good to add also a test where feature is used in transaction. There has been many times errors with stuff working with normal builder, but failing with transactions.

@kibertoad
Copy link
Collaborator Author

@kibertoad kibertoad commented Mar 18, 2019

Just to be safe would be good to add also a test where feature is used in transaction.

Aye!

@kibertoad kibertoad merged commit e7ed005 into master Mar 18, 2019
3 checks passed
@kibertoad kibertoad deleted the fix/3110-raw-querycontext branch Mar 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants