Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pgsql specific table builder method typings #3146

Merged
merged 1 commit into from Jun 19, 2019
Merged

Add pgsql specific table builder method typings #3146

merged 1 commit into from Jun 19, 2019

Conversation

davidspiess
Copy link
Contributor

@davidspiess davidspiess commented Apr 15, 2019

I created PostgreSqlTableBuilder and PostgreSqlAlterTableBuilder interfaces, similar to the existing MySQL counterparts MySqlTableBuilder and MySqlAlterTableBuilder.

They include the currently missing inherits() method.

@kibertoad
Copy link
Collaborator

@kibertoad kibertoad commented Jun 18, 2019

@davidspiess Thank you for your contribution! Sorry it took so long to review it, somehow it slipped through the cracks. Could you please resolve conflicts?

@davidspiess
Copy link
Contributor Author

@davidspiess davidspiess commented Jun 19, 2019

@kibertoad no worries! I rebased my commit on the latest master.

@kibertoad
Copy link
Collaborator

@kibertoad kibertoad commented Jun 19, 2019

Thanks!

@kibertoad kibertoad merged commit f70b726 into knex:master Jun 19, 2019
2 checks passed
@davidspiess davidspiess deleted the pgsql-table-builder-typings branch Jun 19, 2019
@kibertoad
Copy link
Collaborator

@kibertoad kibertoad commented Jun 19, 2019

Released in 0.18.0-next2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants