Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Execute tests on Node 12 #3171

Merged
merged 12 commits into from May 11, 2019
Merged

Execute tests on Node 12 #3171

merged 12 commits into from May 11, 2019

Conversation

@kibertoad
Copy link
Collaborator

@kibertoad kibertoad commented Apr 28, 2019

No description provided.

@kibertoad
Copy link
Collaborator Author

@kibertoad kibertoad commented Apr 28, 2019

Currently blocked by sqlite support: mapbox/node-sqlite3#1151

@DRoet
Copy link

@DRoet DRoet commented May 10, 2019

FYI the upstream issue has been fixed in sqlite 4.0.7

@kibertoad kibertoad requested a review from elhigu May 10, 2019
@kibertoad
Copy link
Collaborator Author

@kibertoad kibertoad commented May 10, 2019

@elhigu Do you prefer to wait with merging this one until Docker tests one lands since this one would be easier to resolve conflicts for?

@@ -60,13 +60,13 @@ services:
addons:
postgresql: '9.6'
apt:
sources:
- mysql-5.7-trusty
Copy link
Collaborator Author

@kibertoad kibertoad May 10, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MySQL 5.7 is default on Xenial, no explicit sources are needed.

.travis.yml Outdated
packages:
- g++-4.8
- gcc-4.8
- g++-5
Copy link
Collaborator Author

@kibertoad kibertoad May 10, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new SQLite version requires gcc 5

@kibertoad
Copy link
Collaborator Author

@kibertoad kibertoad commented May 11, 2019

End changes are not that intrusive (since xenial actually has needed gcc deps by default), so conflict resolution should be in either case quite trivial.

@kibertoad kibertoad merged commit 542ece6 into master May 11, 2019
2 of 3 checks passed
@kibertoad kibertoad deleted the chore/node-12 branch May 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants