Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multi-column whereIn in sqlite through values clause #3220

Merged
merged 1 commit into from May 25, 2019
Merged

Support multi-column whereIn in sqlite through values clause #3220

merged 1 commit into from May 25, 2019

Conversation

@lorefnon
Copy link
Collaborator

@lorefnon lorefnon commented May 25, 2019

Fixes #3042

@kibertoad
Copy link
Collaborator

@kibertoad kibertoad commented May 25, 2019

Nice! Are there any existing integration tests for this that could be expanded to include sqlite?

@lorefnon
Copy link
Collaborator Author

@lorefnon lorefnon commented May 25, 2019

Yeah I have updated them now.

@kibertoad kibertoad merged commit 54a7a4a into knex:master May 25, 2019
2 checks passed
@kibertoad
Copy link
Collaborator

@kibertoad kibertoad commented May 25, 2019

Thanks!

@lorefnon lorefnon deleted the #3042 branch May 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants