Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve count typings #3239

Merged
merged 1 commit into from Jun 1, 2019
Merged

Improve count typings #3239

merged 1 commit into from Jun 1, 2019

Conversation

@lorefnon
Copy link
Collaborator

@lorefnon lorefnon commented Jun 1, 2019

  • Make count generic, especially useful when being used with an alias object argument
  • In case of alias object, partially infer the return type from the input.

Addresses: #3229 (comment)

- Make count generic, especially useful when being used with an alias object argument
- In case of alias object, partially infer the return type from the input.
@kibertoad kibertoad merged commit 9f0da44 into knex:master Jun 1, 2019
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants