Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI/add stub option #3316

Merged
merged 7 commits into from Jul 4, 2019
Merged

CLI/add stub option #3316

merged 7 commits into from Jul 4, 2019

Conversation

the-vampiire
Copy link
Contributor

@the-vampiire the-vampiire commented Jun 28, 2019

closes #3219

adds --stub option to migration:make CLI command

usage

  • --stub <name> looks for stub file by name in config.migrations.directory
  • --stub </file/path> looks for stub file by path relative to knexfile.*

**usage**
-`--stub <name>` looks for stub file by name in `config.migrations.directory`
- `--stub </file/path>` looks for stub file by path relative to `knexfile.*`
- add utilities for testing the --stub option
- add success and failure tests for --stub option
test/cli/migrate-make.spec.js Outdated Show resolved Hide resolved
bin/cli.js Outdated Show resolved Hide resolved
bin/cli.js Outdated Show resolved Hide resolved
test/cli/migrate-make.spec.js Outdated Show resolved Hide resolved
test/cli/migrate-make.spec.js Outdated Show resolved Hide resolved
the-vampiire added 4 commits Jul 1, 2019
- moving the 2 utils getMigrationsExtensions, getStubPath had dependencies
- the depended utils had to be moved over as well and their libs imported
- utils moved: exit, success, resolveEnvironmentConfig, checkLocalModule
- bumped cli-testlab to 1.7.0
- now using new fileHelper glob reader

function getStubPath(env, opts) {
const config = resolveEnvironmentConfig(opts, env.configuration);
const stubDirectory = config.migrations && config.migrations.directory;
Copy link
Contributor Author

@the-vampiire the-vampiire Jul 1, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this could be moved down. doesnt need to be assigned unless func reaches line 133

@kibertoad
Copy link
Collaborator

@kibertoad kibertoad commented Jul 4, 2019

Thanks!

@kibertoad kibertoad merged commit 2b63332 into knex:master Jul 4, 2019
2 checks passed
@kibertoad
Copy link
Collaborator

@kibertoad kibertoad commented Jul 4, 2019

Released in 0.18.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants