Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix remove duplicate transaction promise #3319

Merged
merged 1 commit into from Jun 30, 2019
Merged

Fix remove duplicate transaction promise #3319

merged 1 commit into from Jun 30, 2019

Conversation

vonagam
Copy link
Contributor

@vonagam vonagam commented Jun 30, 2019

Fixes second issue from #3309.

@elhigu
Copy link
Member

@elhigu elhigu commented Jun 30, 2019

Would it be possible to add test case for the bug it fixes?

@vonagam
Copy link
Contributor Author

@vonagam vonagam commented Jun 30, 2019

As i said in the issue - your tests are already sufficient. You can see it in tests logs.

Look: logs for PR that introduced the problem (there are 260 UnhandledPromiseRejectionWarning), logs for this PR (there are none of those).

If you want tests to show rejections more clearly you should force tests to exit with non-zero status on unhandled rejections. How to do it i wrote in the issue. But you need to eliminate other unhandled rejections (there are around ten of them) before you do so.

@kibertoad kibertoad merged commit ee060b4 into knex:master Jun 30, 2019
2 checks passed
@kibertoad
Copy link
Collaborator

@kibertoad kibertoad commented Jun 30, 2019

Thanks! I'll release a fixed version shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants