Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Respect the knexfile stub option while generating a migration #3337

Merged
merged 3 commits into from Jul 10, 2019

Conversation

bohdan-shulha
Copy link
Contributor

@bohdan-shulha bohdan-shulha commented Jul 7, 2019

fixes #3333

@kibertoad
Copy link
Collaborator

@kibertoad kibertoad commented Jul 7, 2019

Thanks! Could you please add test in https://github.com/tgriesser/knex/blob/master/test/cli/migrate-make.spec.js for this case?

@kibertoad kibertoad merged commit c6481e8 into knex:master Jul 10, 2019
2 checks passed
@bohdan-shulha
Copy link
Contributor Author

@bohdan-shulha bohdan-shulha commented Jul 12, 2019

@kibertoad , thanks for the tests and the release, I had no time this week to implement test cases

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants