Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor enhancements around aliasing of aggregates #3354

Merged
merged 1 commit into from Jul 16, 2019
Merged

Minor enhancements around aliasing of aggregates #3354

merged 1 commit into from Jul 16, 2019

Conversation

lorefnon
Copy link
Collaborator

@lorefnon lorefnon commented Jul 16, 2019

  • Allows an options object to specify alias (as suggested in #3315 (comment)) (Closes #3315)
  • Allows multiple aliases when using object syntax (Closes #2871)

@kibertoad
Copy link
Collaborator

@kibertoad kibertoad commented Jul 16, 2019

One test is failing on mssql.

- Allows an options object to specify alias (as suggested in #3315 (comment)) (Closes #3315)
- Allows multiple aliases when using object syntax (Closes #2871)
@lorefnon
Copy link
Collaborator Author

@lorefnon lorefnon commented Jul 16, 2019

@kibertoad this has now been addressed.

@kibertoad kibertoad merged commit 3e1a5ee into knex:master Jul 16, 2019
1 of 2 checks passed
@kibertoad
Copy link
Collaborator

@kibertoad kibertoad commented Jul 16, 2019

I assume this also needsdocumentation update?

@elhigu
Copy link
Member

@elhigu elhigu commented Jul 16, 2019

Added issue for it.

@lorefnon
Copy link
Collaborator Author

@lorefnon lorefnon commented Jul 16, 2019

Yes, I'll take care of that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants