Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update configuration typings to allow for oracle db connectionstring #3361

Merged
merged 1 commit into from Jul 22, 2019
Merged

Update configuration typings to allow for oracle db connectionstring #3361

merged 1 commit into from Jul 22, 2019

Conversation

evansimonross
Copy link
Contributor

@evansimonross evansimonross commented Jul 18, 2019

I am working on a typescript project with an oracle database using SID and we currently have it configured with a custom connectString. We were hoping to move to knex and ran into a typescript issue. Here is the resolution we used to get it working.

@kibertoad kibertoad merged commit ec6091e into knex:master Jul 22, 2019
2 checks passed
@kibertoad
Copy link
Collaborator

@kibertoad kibertoad commented Jul 22, 2019

Thanks!

@kibertoad
Copy link
Collaborator

@kibertoad kibertoad commented Jul 23, 2019

Released in 0.19.1

@evansimonross evansimonross deleted the oracle-db-typing branch Jul 24, 2019
@evansimonross
Copy link
Contributor Author

@evansimonross evansimonross commented Jul 24, 2019

Thanks very much! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants