Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#3367 Add interface for PG Connection object #3372

Merged
merged 5 commits into from Oct 26, 2019

Conversation

@timorthi
Copy link
Contributor

timorthi commented Jul 26, 2019

Closes #3367

statement_timeout?: false | number;
}

type RedshiftConnectionConfig = PgConnectionConfig;

This comment has been minimized.

Copy link
@timorthi

timorthi Jul 26, 2019

Author Contributor

Figured I'd sneak this in since the Redshift dialect uses the same driver.

@timorthi timorthi changed the title Add interface for PG Connection object #3367 Add interface for PG Connection object Jul 26, 2019
@kibertoad

This comment has been minimized.

Copy link
Collaborator

kibertoad commented Oct 25, 2019

Could you please update the PR to make sure build passes?

@kibertoad

This comment has been minimized.

Copy link
Collaborator

kibertoad commented Oct 26, 2019

Thanks!

@kibertoad kibertoad merged commit d806ec0 into knex:master Oct 26, 2019
1 check failed
1 check failed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
@timorthi timorthi deleted the timorthi:pgconnection-type branch Oct 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.