More consistent handling of nested transactions #3393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t on rollback, test
kibertoad
reviewed
Aug 14, 2019
| @@ -18,7 +17,7 @@ matrix: | |||
| env: TESTSCRIPT=test:nyc DB="oracledb mssql mysql mysql2 postgres sqlite3" KNEX_TEST_TIMEOUT=60000 | |||
| install: | |||
| - npm i | |||
| - (echo $DB | grep oracledb) && npm install oracledb || true | |||
| - (echo $DB | grep oracledb) && npm install oracledb@3.1.2 || true | |||
There was a problem hiding this comment.
See #3396 for the reason of this change.
4 tasks
added 2 commits
Aug 16, 2019
…/github.com/tgriesser/knex into improvement/3389-nested-trxs
|
Is there need to add more info about nested transactions and how rejections are happening to documentation? |
|
@elhigu I'll review it just in case. |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
fixes #3389 #3320