Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More consistent handling of nested transactions #3393

Merged
merged 5 commits into from Aug 16, 2019

Conversation

kibertoad
Copy link
Collaborator

@kibertoad kibertoad commented Aug 13, 2019

fixes #3389 #3320

@kibertoad kibertoad requested a review from elhigu Aug 13, 2019
@@ -18,7 +17,7 @@ matrix:
env: TESTSCRIPT=test:nyc DB="oracledb mssql mysql mysql2 postgres sqlite3" KNEX_TEST_TIMEOUT=60000
install:
- npm i
- (echo $DB | grep oracledb) && npm install oracledb || true
- (echo $DB | grep oracledb) && npm install oracledb@3.1.2 || true
Copy link
Collaborator Author

@kibertoad kibertoad Aug 14, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #3396 for the reason of this change.

@kibertoad kibertoad merged commit 871dadb into master Aug 16, 2019
3 checks passed
@kibertoad kibertoad deleted the improvement/3389-nested-trxs branch Aug 16, 2019
@elhigu
Copy link
Member

@elhigu elhigu commented Aug 16, 2019

Is there need to add more info about nested transactions and how rejections are happening to documentation?

@kibertoad
Copy link
Collaborator Author

@kibertoad kibertoad commented Aug 16, 2019

@elhigu I'll review it just in case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants