Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeScript definition: include schemaName in EnumOptions #3415

Merged
merged 2 commits into from Aug 26, 2019
Merged

TypeScript definition: include schemaName in EnumOptions #3415

merged 2 commits into from Aug 26, 2019

Conversation

ivanovych666
Copy link
Contributor

@ivanovych666 ivanovych666 commented Aug 26, 2019

This is addition to #3413

@kibertoad
Copy link
Collaborator

@kibertoad kibertoad commented Aug 26, 2019

@ivanovych666 Can you mark optional ones as optional, while we are at it, btw?

@kibertoad
Copy link
Collaborator

@kibertoad kibertoad commented Aug 26, 2019

Awesome, thank you!

@kibertoad kibertoad merged commit 3f86d75 into knex:master Aug 26, 2019
1 of 2 checks passed
@ivanovych666 ivanovych666 deleted the issues-3307 branch Oct 6, 2019
@ivanovych666 ivanovych666 restored the issues-3307 branch Oct 6, 2019
@ivanovych666 ivanovych666 deleted the issues-3307 branch Oct 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants