Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes types for Seeder#run #3438

Merged
merged 2 commits into from Oct 14, 2019
Merged

Fixes types for Seeder#run #3438

merged 2 commits into from Oct 14, 2019

Conversation

ksmithut
Copy link
Contributor

@ksmithut ksmithut commented Sep 12, 2019

The seed.run command returns a array of a single item, and that item contains the array of strings (filepaths of seeds that were run).

This comes from here:

The `seed.run` command returns a array of a single item, and that item contains the array of strings (filepaths of seeds that were run).
@kibertoad kibertoad closed this Oct 14, 2019
@kibertoad kibertoad reopened this Oct 14, 2019
@ksmithut
Copy link
Contributor Author

@ksmithut ksmithut commented Oct 14, 2019

The test failures seem intermittent, but I could be wrong. Is there a way to trigger another run or is that test failure legitimate?

@kibertoad kibertoad merged commit 767904c into knex:master Oct 14, 2019
1 check failed
@kibertoad
Copy link
Collaborator

@kibertoad kibertoad commented Oct 14, 2019

yeah, that one is not important. Thanks!

@ksmithut ksmithut deleted the patch-1 branch Oct 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants