Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This is a patch to fix issues #1901, #2990 and #2991 #3449

Merged
merged 3 commits into from Sep 22, 2019

Conversation

@oitTim
Copy link
Contributor

oitTim commented Sep 21, 2019

We use Oracle stored procedures and get the error 'expecting an array or an iterable object but got [object Null]' . This bugfix is kind of important as we convert old MuleSoft flows to Node endpoints.

Let me know if you need any more information or documentation.

@@ -36,6 +36,7 @@
"liftoff": "3.1.0",
"lodash": "^4.17.15",
"mkdirp": "^0.5.1",
"oracledb": "^4.0.1",

This comment has been minimized.

Copy link
@kibertoad

kibertoad Sep 21, 2019

Collaborator

It would be preferable to avoid adding this, but instead move tests to integration test suite and skipping it for non-oracle dbs.

This comment has been minimized.

Copy link
@oitTim

oitTim Sep 21, 2019

Author Contributor

Where in the integrations folder should I place the tests?

This comment has been minimized.

Copy link
@kibertoad

kibertoad Sep 21, 2019

Collaborator

I'd say that https://github.com/tgriesser/knex/tree/master/test/integration/builder, probablyadditional, since I assume this is not a select per se?

oitTim added 2 commits Sep 21, 2019
@elhigu

This comment has been minimized.

Copy link
Member

elhigu commented Sep 22, 2019

Did we have some wiki or cookbook for knex? That kind of entry would be great for documentation. Also great work, this has been very wanted feature 👍

@elhigu
elhigu approved these changes Sep 22, 2019
Copy link
Member

elhigu left a comment

Flawless victory!

@oitTim

This comment has been minimized.

Copy link
Contributor Author

oitTim commented Sep 22, 2019

I will create a cookbook on how to call an oracle stored procedure and get the results :D

@elhigu

This comment has been minimized.

Copy link
Member

elhigu commented Sep 22, 2019

@oitTim

This comment has been minimized.

Copy link
Contributor Author

oitTim commented Sep 22, 2019

Simple example added to the recipe.

@kibertoad kibertoad merged commit 68e1ae2 into knex:master Sep 22, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.005%) to 87.891%
Details
@kibertoad

This comment has been minimized.

Copy link
Collaborator

kibertoad commented Oct 6, 2019

Released in 0.19.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.