Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove bluebird.each #3471

Merged
merged 3 commits into from Oct 12, 2019

Conversation

@maximelkin
Copy link
Contributor

maximelkin commented Oct 8, 2019

closes #3256

maxeljkin added 3 commits Oct 8, 2019
@kibertoad kibertoad closed this Oct 9, 2019
@kibertoad kibertoad reopened this Oct 9, 2019
@maximelkin

This comment has been minimized.

Copy link
Contributor Author

maximelkin commented Oct 9, 2019

@kibertoad maybe its better to merge all prs in one?

@@ -128,7 +129,7 @@ Client_Oracledb.prototype.acquireRawConnection = function() {
});
});
};
const fetchAsync = function(sql, bindParams, options, cb) {
const fetchAsync = promisify(function(sql, bindParams, options, cb) {

This comment has been minimized.

Copy link
@kibertoad

kibertoad Oct 11, 2019

Collaborator

Does this function use any closure variables, or it can be moved outside to only be promisified once?

This comment has been minimized.

Copy link
@maximelkin

maximelkin Oct 11, 2019

Author Contributor

This function use connection from outside

@kibertoad

This comment has been minimized.

Copy link
Collaborator

kibertoad commented Oct 11, 2019

@maximelkin Keeping PRs separate makes them easier to review :)

@kibertoad kibertoad merged commit 4a71315 into knex:master Oct 12, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.07%) to 87.876%
Details
@maximelkin maximelkin deleted the maximelkin:bluebird_remove_each branch Oct 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.