Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bluebird remove map mapSeries #3474

Merged
merged 2 commits into from Oct 11, 2019

Conversation

maximelkin
Copy link
Collaborator

@maximelkin maximelkin commented Oct 9, 2019

No description provided.

@maximelkin maximelkin force-pushed the bluebird_remove_map_mapSeries branch from f9b6219 to bc6e265 Compare Oct 10, 2019
@maximelkin maximelkin changed the title Bluebird remove map mapSeries WIP: Bluebird remove map mapSeries Oct 10, 2019
@maximelkin
Copy link
Collaborator Author

@maximelkin maximelkin commented Oct 10, 2019

Trying to find where unhandledRejection occurs, currently set WIP

@maximelkin maximelkin force-pushed the bluebird_remove_map_mapSeries branch from bc6e265 to 399f7bf Compare Oct 10, 2019
@maximelkin maximelkin changed the title WIP: Bluebird remove map mapSeries Bluebird remove map mapSeries Oct 10, 2019
@maximelkin
Copy link
Collaborator Author

@maximelkin maximelkin commented Oct 10, 2019

So it was from manual transactions, rewrite using callback-style

@kibertoad kibertoad merged commit f56eaf5 into knex:master Oct 11, 2019
1 check passed
@kibertoad
Copy link
Collaborator

@kibertoad kibertoad commented Oct 11, 2019

Fantastic work, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants