Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bugs in replacement logic used when dropping columns in SQLite. #3476

Merged
merged 1 commit into from Oct 11, 2019

Conversation

@lorefnon
Copy link
Collaborator

lorefnon commented Oct 11, 2019

  1. Fix regex match failure when table has not been created through knex's createTable (Closes #3473)
  2. Handle all quote variants supported by SQLite.
  3. Fix incorrect handling of foreign keys & constraints
1. Fix regex match failure when table has not been created through knex's createTable (Closes #3473)
2. Handle all quote variants supported by SQLite.
3. Fix incorrect handling of foreign keys & constraints
@kibertoad kibertoad merged commit 20bd04b into master Oct 11, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.