Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Oracle error codes #3498

Merged
merged 1 commit into from Oct 28, 2019
Merged

Fix Oracle error codes #3498

merged 1 commit into from Oct 28, 2019

Conversation

abskmj
Copy link
Contributor

@abskmj abskmj commented Oct 28, 2019

Updated some of the incorrect Oracle codes (ORA-XXXXX) to correct values.

@maximelkin
Copy link
Collaborator

@maximelkin maximelkin commented Oct 28, 2019

You are fixing old oracle driver (https://www.npmjs.com/package/oracle), is this intended?

@abskmj
Copy link
Contributor Author

@abskmj abskmj commented Oct 28, 2019

The new oracle driver inherits from the old one and is using these codes. Yes, it's intended.

@kibertoad
Copy link
Collaborator

@kibertoad kibertoad commented Oct 28, 2019

@abskmj Could you please point me in the direction of reference source you used for correct codes?

@abskmj
Copy link
Contributor Author

@abskmj abskmj commented Oct 28, 2019

This official page has the details: https://docs.oracle.com/cd/B28359_01/server.111/b28278/toc.htm

@kibertoad kibertoad merged commit 1f4d8f2 into knex:master Oct 28, 2019
1 check passed
@abskmj abskmj deleted the bugfix/oracle-error-codes branch Oct 29, 2019
@kibertoad
Copy link
Collaborator

@kibertoad kibertoad commented Oct 29, 2019

Released in 0.20.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants