Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Oracle error codes #3498

Merged
merged 1 commit into from Oct 28, 2019

Conversation

@abskmj
Copy link
Contributor

abskmj commented Oct 28, 2019

Updated some of the incorrect Oracle codes (ORA-XXXXX) to correct values.

@maximelkin

This comment has been minimized.

Copy link
Contributor

maximelkin commented Oct 28, 2019

You are fixing old oracle driver (https://www.npmjs.com/package/oracle), is this intended?

@abskmj

This comment has been minimized.

Copy link
Contributor Author

abskmj commented Oct 28, 2019

The new oracle driver inherits from the old one and is using these codes. Yes, it's intended.

@kibertoad

This comment has been minimized.

Copy link
Collaborator

kibertoad commented Oct 28, 2019

@abskmj Could you please point me in the direction of reference source you used for correct codes?

@abskmj

This comment has been minimized.

Copy link
Contributor Author

abskmj commented Oct 28, 2019

@kibertoad kibertoad merged commit 1f4d8f2 into knex:master Oct 28, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@abskmj abskmj deleted the abskmj:bugfix/oracle-error-codes branch Oct 29, 2019
@kibertoad

This comment has been minimized.

Copy link
Collaborator

kibertoad commented Oct 29, 2019

Released in 0.20.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.