Gracefully handle global promise pollution #3502
+1
−1
| @@ -1401,7 +1401,7 @@ declare namespace Knex { | ||
| // Chainable interface | ||
| // | ||
|
|
||
| interface ChainableInterface<T = any> extends Promise<T> { | ||
| interface ChainableInterface<T = any> extends Pick<Promise<T>, "then" | "catch" | "finally"> { | ||
|
This conversation was marked as resolved
by elhigu
|
||
| toQuery(): string; | ||
| options(options: { [key: string]: any }): this; | ||
| connection(connection: any): this; | ||
ProTip!
Use n and p to navigate between commits in a pull request.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Does promise have "finally" method? I thought it was just a bluebird thing.