Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gracefully handle global promise pollution #3502

Merged
merged 1 commit into from Oct 29, 2019
Merged
Changes from all commits
Commits
File filter...
Filter file types
Jump to…
Jump to file or symbol
Failed to load files and symbols.

Always

Just for now

@@ -1401,7 +1401,7 @@ declare namespace Knex {
// Chainable interface
//

interface ChainableInterface<T = any> extends Promise<T> {
interface ChainableInterface<T = any> extends Pick<Promise<T>, "then" | "catch" | "finally"> {
This conversation was marked as resolved by elhigu

This comment has been minimized.

Copy link
@elhigu

elhigu Oct 31, 2019

Member

Does promise have "finally" method? I thought it was just a bluebird thing.

This comment has been minimized.

Copy link
@onehorsetown

onehorsetown Oct 31, 2019

The Typescriptlib.es2018.promise.d.ts definition added finally

https://github.com/microsoft/TypeScript/blob/234680851bbbe83dd6bcd8aac165a57adbf586e2/src/lib/es2018.promise.d.ts#L11

I don't follow the whole feature ratification process. I just know finally works in Node 12.

toQuery(): string;
options(options: { [key: string]: any }): this;
connection(connection: any): this;
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.