Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix QueryBuilder.extend this type (#3526) #3528

Merged
merged 1 commit into from Dec 7, 2019

Conversation

@iki
Copy link
Contributor

iki commented Nov 8, 2019

@lorefnon

This comment has been minimized.

Copy link
Collaborator

lorefnon commented Nov 17, 2019

It seems that the test suite is failing because QueryBuilder type doesn't declare client property.

This has been addressed in #3541.

@kibertoad

This comment has been minimized.

Copy link
Collaborator

kibertoad commented Nov 21, 2019

@iki Could you please rebase the PR?

@kibertoad

This comment has been minimized.

Copy link
Collaborator

kibertoad commented Nov 27, 2019

@lorefnon @iki

Error: /home/travis/build/knex/knex/types/test.ts:14:34
ERROR: 14:34  expect  TypeScript@next compile error: 
Property 'raw' does not exist on type 'Client'.
    at /home/travis/build/knex/knex/node_modules/dtslint/bin/index.js:193:19
    at Generator.next (<anonymous>)
    at fulfilled (/home/travis/build/knex/knex/node_modules/dtslint/bin/index.js:6:58)
    at <anonymous>

Wonder if tests are wrong or types.

@iki iki force-pushed the iki:fix/querybuilder-extend-this-type branch from 0c4819a to a9cc638 Nov 28, 2019
@kibertoad

This comment has been minimized.

Copy link
Collaborator

kibertoad commented Nov 28, 2019

@iki Type tests are still failing.

@lorefnon

This comment has been minimized.

Copy link
Collaborator

lorefnon commented Nov 29, 2019

I didnt notice that Client types are very incomplete. I can check on this tomorrow.

@kibertoad kibertoad requested a review from lorefnon Dec 5, 2019
@lorefnon

This comment has been minimized.

Copy link
Collaborator

lorefnon commented Dec 7, 2019

I couldn't take this up last week. I have added missing methods of Client type in #3565.

Many of them are still incomplete because many types that Client depends on also don't have definitions. I am hoping to address this better as a part of #3521.

But I have verified that that pr fixes the type errors in this one.

@kibertoad

This comment has been minimized.

Copy link
Collaborator

kibertoad commented Dec 7, 2019

@iki I've merged #3565, could you please rebase now?

@iki iki force-pushed the iki:fix/querybuilder-extend-this-type branch from a9cc638 to 1df4d7f Dec 7, 2019
@iki

This comment has been minimized.

Copy link
Contributor Author

iki commented Dec 7, 2019

@kibertoad done
@lorefnon thanks for the fix!

@kibertoad kibertoad merged commit c72b955 into knex:master Dec 7, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.