Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lift up dialect specific methods in the CreateTableBuilder #3532

Merged
merged 3 commits into from Nov 21, 2019
Merged

Conversation

@lorefnon
Copy link
Collaborator

lorefnon commented Nov 10, 2019

@lorefnon lorefnon force-pushed the #3478 branch from 5f66dd0 to 6247b24 Nov 12, 2019
@lorefnon lorefnon force-pushed the #3478 branch from 6247b24 to 53441fa Nov 13, 2019
@kibertoad

This comment has been minimized.

Copy link
Collaborator

kibertoad commented Nov 14, 2019

@lorefnon

 2) Integration Tests

       oracle | oracledb

         Joins

           accepts a callback as the second argument for advanced joins:

     select * from "accounts" left join "test_table_two" on "accounts"."id" = "test_table_two"."account_id" or "accounts"."email" = "test_table_two"."details" order by "accounts"."id" asc - ORA-00932: inconsistent datatypes: expected - got CLOB

  Error: ORA-00932: inconsistent datatypes: expected - got CLOB

      at Client_Oracledb._query (lib/dialects/oracledb/index.js:246:19)

      at Client_Oracledb.query (lib/client.js:165:17)

      at Runner.query (lib/runner.js:135:36)

      at /home/travis/build/knex/knex/lib/runner.js:39:23

  From previous event:

      at Runner.run (lib/runner.js:25:16)

      at Builder.Target.then (lib/interface.js:14:43)

I think this is a new failure. Can you check it out?

@lorefnon

This comment has been minimized.

Copy link
Collaborator Author

lorefnon commented Nov 15, 2019

@kibertoad yeah, this broke due to an accidental change. Fixed now.

@kibertoad kibertoad merged commit 79ccb7d into master Nov 21, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@kibertoad kibertoad deleted the #3478 branch Nov 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.