Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add connection string qs to connection params #3547

Merged
merged 3 commits into from Nov 21, 2019
Merged

Conversation

@AndreiIgna
Copy link
Contributor

AndreiIgna commented Nov 20, 2019

Like mentioned in here #2354 (comment) this will allow query string params to be passed to driver used. It already works like this in other libraries, and seems like it be helpful for multiple cases.

Example in MySql https://github.com/mysqljs/mysql/blob/master/lib/ConnectionConfig.js#L186

@kibertoad

This comment has been minimized.

Copy link
Collaborator

kibertoad commented Nov 20, 2019

Thanks! Could you add test for this?

@AndreiIgna

This comment has been minimized.

Copy link
Contributor Author

AndreiIgna commented Nov 20, 2019

Added, tests seem to be failing for an unrelated part than this change

@kibertoad kibertoad merged commit 07276bc into knex:master Nov 21, 2019
1 check failed
1 check failed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
@kibertoad

This comment has been minimized.

Copy link
Collaborator

kibertoad commented Nov 27, 2019

Released in 0.20.3

@AndreiIgna

This comment has been minimized.

Copy link
Contributor Author

AndreiIgna commented Nov 28, 2019

That's great 👍 just tested it and works fine in my project

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.