Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix colors in debug logs #3592

Merged
merged 2 commits into from Dec 28, 2019
Merged

Fix colors in debug logs #3592

merged 2 commits into from Dec 28, 2019

Conversation

@lorefnon
Copy link
Collaborator

lorefnon commented Dec 22, 2019

Resolves #3588

} = config;
this._inspectionDepth = inspectionDepth || 5;
this._enableColors = isNil(enableColors) ? process.stdout.isTTY : enableColors;

This comment has been minimized.

Copy link
@kibertoad

kibertoad Dec 22, 2019

Collaborator

is process.stdout.isTTY available in browser? does this need defensive access chaining?

@kibertoad

This comment has been minimized.

Copy link
Collaborator

kibertoad commented Dec 27, 2019

Igor Savin
@kibertoad kibertoad merged commit 3914bf5 into master Dec 28, 2019
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/travis-ci/push The Travis CI build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@kibertoad kibertoad deleted the #3588 branch Dec 28, 2019
@lorefnon

This comment has been minimized.

Copy link
Collaborator Author

lorefnon commented Dec 30, 2019

@kibertoad Thanks for taking care of this.

I have been travelling over the vacations and didn't get a chance to look into the above.

@kibertoad

This comment has been minimized.

Copy link
Collaborator

kibertoad commented Dec 30, 2019

np, thank you for the fix itself!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.