Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): prevent warning showing up with root command #3604

Merged
merged 1 commit into from Jan 4, 2020

Conversation

@jamesgeorge007
Copy link
Contributor

jamesgeorge007 commented Jan 2, 2020

closes #3603

Tweaked the code-base to make use of commander.js API that handles the scenario when no arguments were passed in.

@kibertoad kibertoad merged commit df2ace1 into knex:master Jan 4, 2020
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@kibertoad

This comment has been minimized.

Copy link
Collaborator

kibertoad commented Jan 4, 2020

Thanks!

@jamesgeorge007 jamesgeorge007 deleted the jamesgeorge007:hotfix/cli-tweak branch Jan 5, 2020
simon-lorenz pushed a commit to simon-lorenz/knex that referenced this pull request Jan 10, 2020
This reverts commit df2ace1.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.