Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dispose Oracle connection on connection error #3611

Merged
merged 3 commits into from Jan 5, 2020

Conversation

@jakecoffman
Copy link
Contributor

jakecoffman commented Jan 5, 2020

added a test for PR #3537

@kibertoad

This comment has been minimized.

Copy link
Collaborator

kibertoad commented Jan 5, 2020

Wow! Thank you so much!

@kibertoad kibertoad merged commit 2255820 into knex:master Jan 5, 2020
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jakecoffman

This comment has been minimized.

Copy link
Contributor Author

jakecoffman commented Jan 5, 2020

I'd like to fix #3612 too but I probably can't get to it until tomorrow.

@kibertoad

This comment has been minimized.

Copy link
Collaborator

kibertoad commented Jan 5, 2020

@jakecoffman Should I wait with releasing a new version of knex until then?

@jakecoffman

This comment has been minimized.

Copy link
Contributor Author

jakecoffman commented Jan 6, 2020

@kibertoad It looks like there is more that I don't understand yet. You shouldn't wait for me to figure this out, might be a while! Thanks

@jakecoffman jakecoffman deleted the jakecoffman:oracle-connection-dispose branch Jan 6, 2020
@kibertoad

This comment has been minimized.

Copy link
Collaborator

kibertoad commented Jan 7, 2020

Released in knex@0.20.7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.