Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor more tests to use cli-testlab #3640

Merged
merged 2 commits into from Jan 28, 2020
Merged

Refactor more tests to use cli-testlab #3640

merged 2 commits into from Jan 28, 2020

Conversation

@kibertoad
Copy link
Collaborator

kibertoad commented Jan 28, 2020

No description provided.


module.exports = function parseConnectionString(str) {
const parsed = url.parse(str, true);
let { protocol } = parsed;
if (protocol === null) {
const isDriveLetter = isWindows && protocol.length === 2;

This comment has been minimized.

Copy link
@kibertoad

kibertoad Jan 28, 2020

Author Collaborator

Original implementation didn't support sqlite paths to begin with drive letter, e. g. "c:/knex/migrations"

Igor Savin
@kibertoad kibertoad merged commit c14252d into master Jan 28, 2020
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@kibertoad kibertoad deleted the chore/refactor-cli-test branch Jan 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.