Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oracledb: commit was a no-op causing race conditions #3668

Merged
merged 3 commits into from Feb 16, 2020

Conversation

@jakecoffman
Copy link
Contributor

jakecoffman commented Feb 16, 2020

fix #3612

jakecoffman added 3 commits Jan 6, 2020
The underlying issue was that query *always* committed, even during a transaction. The previous fix was to just disable commitAsync in a transaction but then that also disabled explicit commit calls. Instead, this fix disables query's commits during transactions so that explicit commits still work.
@kibertoad

This comment has been minimized.

Copy link
Collaborator

kibertoad commented Feb 16, 2020

@akaraivanov @jakecoffman I assume this still needs new unit tests with Sinon mocks?

@kibertoad

This comment has been minimized.

Copy link
Collaborator

kibertoad commented Feb 16, 2020

refs #3225

@jakecoffman

This comment has been minimized.

Copy link
Contributor Author

jakecoffman commented Feb 16, 2020

I'm trying to see if the integration tests I enabled will fail in travis so I am running them repeatedly. Would that be enough to say that this fix is tested? It would probably be more meaningful than a mocked out db call.

@kibertoad

This comment has been minimized.

Copy link
Collaborator

kibertoad commented Feb 16, 2020

Yeah, fair :)

@kibertoad

This comment has been minimized.

Copy link
Collaborator

kibertoad commented Feb 16, 2020

Seem to be green, so at least not worse than before. Let's land this and observe oracle behaviour in master over longer period of time.

@kibertoad kibertoad merged commit d50d006 into knex:master Feb 16, 2020
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.