Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use "collate nocase" in sqlite order by, because it makes things t... #396

Merged
merged 3 commits into from Aug 11, 2014

Conversation

@sweetpi
Copy link
Contributor

@sweetpi sweetpi commented Jul 25, 2014

...errible slow, because no index is used.

The story behind it: pimatic/pimatic#206

@tgriesser
Copy link
Member

@tgriesser tgriesser commented Jul 28, 2014

Interesting, thanks! I'll merge this sometime this week and cut a new minor version.

@sweetpi
Copy link
Contributor Author

@sweetpi sweetpi commented Jul 29, 2014

Thanks, that would be nice.

@sweetpi
Copy link
Contributor Author

@sweetpi sweetpi commented Aug 6, 2014

Any news here? Would love to update my dependencies :)

tgriesser added a commit that referenced this pull request Aug 11, 2014
Don't use "collate nocase" in sqlite order by, because it makes things t...
@tgriesser tgriesser merged commit 8cfd8df into knex:master Aug 11, 2014
1 check passed
1 check passed
@tgriesser
continuous-integration/travis-ci The Travis CI build passed
Details
@tgriesser tgriesser mentioned this pull request Sep 2, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants