Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed offset without limit for mysql and sqlite3 #446

Merged
merged 1 commit into from Aug 28, 2014

Conversation

@vschoettke
Copy link
Collaborator

@vschoettke vschoettke commented Aug 28, 2014

SQLite3 and MySQL do not support offset without limit. So I implemented the recommended workaround (See URLs in the source)

MySQL:

To retrieve all rows from a certain offset up to the end of the result set, you can use some large number for the second parameter. This statement retrieves all rows from the 96th row to the last:

SELECT * FROM tbl LIMIT 95,18446744073709551615;

SQLite3:

If the LIMIT expression evaluates to a negative value, then there is no upper bound on the number of rows returned.

vschoettke added a commit that referenced this pull request Aug 28, 2014
Fixed offset without limit for mysql and sqlite3
@vschoettke vschoettke merged commit f3bff2d into knex:master Aug 28, 2014
1 check passed
1 check passed
@vschoettke
continuous-integration/travis-ci The Travis CI build passed
Details
@vschoettke vschoettke deleted the vschoettke:fix-offset-without-limit branch Aug 28, 2014
@tgriesser tgriesser mentioned this pull request Sep 2, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant