-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #5184, ensure Typescript developer experience doesn't influence user experience #5185
Fix #5184, ensure Typescript developer experience doesn't influence user experience #5185
Conversation
@kibertoad or @OlivierCavadenti please have all tests run and if they pass I'll update description and convert from draft for review! |
@code-ape integration tests got nuked somehow |
@kibertoad it's because I'm an outside contributor and changed that CI file. I think there should be some way for you to "approve and run it"? Correction: It's because I messed up the YAML 😅 |
@code-ape I think restriction only applies to first-time committers, CI should kick-in automatically for you. |
f98a5f8
to
fe6bbd4
Compare
cef0dce
to
93ee7aa
Compare
@kibertoad and @OlivierCavadenti, draft status removed, description updated to describe all changes, and all CI tests passing. Handing it off to you to do as you will 😄 |
Related PRs and Issues
Reason
#5151 caused all end user installs of Knex to fail due to single line in
package.json
. Intention was that when developers rannpm install
while working on Knex it would automatically build the Typescript files. This was a mistake and it should be a Husky script for the git hookpost-checkout
.Changes
postInstall
andprepublishOnly
hooks toprepare
hook inpackage.json
.package.json
.files
section to properly exclude non-publishablelib/
files inpackage.json
.build:gitignore
to work on Windows inpackage.json
.CONTRIBUTING.md
..github/workflows/integration-tests.yml
.package.json
..husky/pre-commit
..gitignore
.