Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI support for knexfiles that do not provide environment keys #527

Merged
merged 2 commits into from Nov 11, 2014

Conversation

@bendrucker
Copy link
Member

@bendrucker bendrucker commented Oct 12, 2014

@tgriesser Seems like this should be a pretty safe change but I'll leave for you to merge

Closes #328

bendrucker added 2 commits Oct 12, 2014
Scenario 1: Environment is defined via --env or NODE_ENV
* config is config[environment]

Scenario 2: Environment is undefined but config.development is an object
* config is config.development

Scenario 3: No environment and no config.development
* config is config

Also logs out the environment in use for scenarios 1 and 2
bendrucker added a commit that referenced this issue Nov 11, 2014
CLI support for knexfiles that do not provide environment keys
@bendrucker bendrucker merged commit eacb6c3 into master Nov 11, 2014
1 check passed
elliotf pushed a commit to elliotf/knex that referenced this issue Nov 24, 2014
@bendrucker bendrucker mentioned this pull request Dec 4, 2014
@tgriesser tgriesser deleted the cli-without-env branch Feb 25, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

1 participant