Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support POSIX regex matching. #562

Closed
wants to merge 3 commits into from
Closed

Conversation

@villelahdenvuo
Copy link
Contributor

@villelahdenvuo villelahdenvuo commented Nov 14, 2014

Fixes #561

@bendrucker
Copy link
Member

@bendrucker bendrucker commented Nov 14, 2014

Can you get tests written against this (unit)? Happy to merge afterwards.

@villelahdenvuo
Copy link
Contributor Author

@villelahdenvuo villelahdenvuo commented Nov 14, 2014

I guess I'll have to since I need this for our work project. 😉

@villelahdenvuo
Copy link
Contributor Author

@villelahdenvuo villelahdenvuo commented Nov 14, 2014

@bendrucker I think there should be some kind of celebration, this is the 1337th test. 🎉

Is this enough? I really don't know what should be tested more since it's a simple addition to the operators list.

@bendrucker
Copy link
Member

@bendrucker bendrucker commented Nov 14, 2014

Celebration indeed! That's fine, thanks!

@villelahdenvuo villelahdenvuo deleted the villelahdenvuo:patch-1 branch Nov 14, 2014
tgriesser added a commit that referenced this pull request Feb 25, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants