Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add nested having support #572

Merged
merged 2 commits into from Nov 20, 2014
Merged

add nested having support #572

merged 2 commits into from Nov 20, 2014

Conversation

@PhilWaldmann
Copy link

@PhilWaldmann PhilWaldmann commented Nov 20, 2014

where supports nested conditions via

.where(function(){
  this.orWhere(...);
  this.orWhere(...)
});

with this PR the same is possible for having

.having(function(){
  this.orWhere(...);
  this.orWhere(...)
});

I've included 2 simple tests

tgriesser added a commit that referenced this pull request Nov 20, 2014
@tgriesser tgriesser merged commit f66efd8 into knex:master Nov 20, 2014
1 check passed
1 check passed
@tgriesser
continuous-integration/travis-ci The Travis CI build passed
Details
@tgriesser
Copy link
Member

@tgriesser tgriesser commented Nov 20, 2014

Ah, good idea! Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants