Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not push undefined connections back into the pool #85

merged 1 commit into from Oct 2, 2013


Copy link

@achicu achicu commented Oct 2, 2013

If the connection fails because of a server error, the code pushes an undefined connection back into the pool.

tgriesser added a commit that referenced this issue Oct 2, 2013
Do not push undefined connections back into the pool
@tgriesser tgriesser merged commit 71a2198 into knex:master Oct 2, 2013
1 check passed
Copy link

@tgriesser tgriesser commented Oct 2, 2013

Good catch, thanks @achicu!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants