Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added charset() and collate() for mysql schema builder #89

Merged
merged 2 commits into from Oct 14, 2013
Merged

added charset() and collate() for mysql schema builder #89

merged 2 commits into from Oct 14, 2013

Conversation

@oohnoitz
Copy link
Contributor

@oohnoitz oohnoitz commented Oct 10, 2013

When creating a table in MySQL, we should be able to set the charset and collation of that table instead of using the connection's charset. This only applies to MySQL since PostgreSQL and SQLite has it applied to the entire database.

tgriesser added a commit that referenced this pull request Oct 14, 2013
added charset() and collate() for mysql schema builder
@tgriesser tgriesser merged commit e277f90 into knex:master Oct 14, 2013
1 check passed
1 check passed
@tgriesser
default The Travis CI build passed
Details
@tgriesser
Copy link
Member

@tgriesser tgriesser commented Oct 14, 2013

Nice, thanks @oohnoitz!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants